Skip to content

ci: add 180-minute timeout to test-suite jobs#22362

Open
jorgsowa wants to merge 1 commit into
php:PHP-8.4from
jorgsowa:ci/workflow-job-timeouts
Open

ci: add 180-minute timeout to test-suite jobs#22362
jorgsowa wants to merge 1 commit into
php:PHP-8.4from
jorgsowa:ci/workflow-job-timeouts

Conversation

@jorgsowa

Copy link
Copy Markdown
Contributor

Most jobs had no timeout minutes and fell back to GitHub's 6-hour default, so a hung step wasted ~6h of runner time. Cap all jobs at 180 min, which clears the slowest nightly runs.

Hitting the 6h ceiling:

Slowest passing jobs:

The GitHub-hosted test-suite jobs had no timeout-minutes and fell back
to GitHub's 6-hour default, so a hung step (e.g. apt) wasted ~6h of
runner time. Cap them at 180 min, which clears the slowest legitimate
nightly runs (LINUX_X64_ASAN ~158 min) with margin. The self-hosted
jobs keep their existing 50-minute caps.

@Ayesh Ayesh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We already use timeouts in other workflows, and I think 180 makes a good limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants